Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

report: refactor getReport() argument validation and increase test coverage #26276

Merged
merged 2 commits into from
Feb 26, 2019
Merged

report: refactor getReport() argument validation and increase test coverage #26276

merged 2 commits into from
Feb 26, 2019

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Feb 23, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@cjihrig sadly an error occured when I tried to trigger a build :(

@nodejs-github-bot nodejs-github-bot added the process Issues and PRs related to the process subsystem. label Feb 23, 2019
@cjihrig
report: refactor argument validation
fe8c1f6 
PR-URL: nodejs#26276
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@cjihrig
test: increase getReport() coverage
9d44950 
PR-URL: nodejs#26276
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@cjihrig
Copy link
Contributor Author

cjihrig commented Feb 26, 2019

Yellow CI: https://ci.nodejs.org/job/node-test-pull-request/21009/

@cjihrig cjihrig merged commit 9d44950 into nodejs:master Feb 26, 2019
@cjihrig
Copy link
Contributor Author

cjihrig commented Feb 26, 2019

Landed in 72cf8a3...9d44950.

@cjihrig cjihrig deleted the get-report branch February 26, 2019 23:08
addaleax pushed a commit that referenced this pull request Mar 1, 2019
@cjihrig @addaleax
report: refactor argument validation
6d2a14d 
PR-URL: #26276
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit that referenced this pull request Mar 1, 2019
@cjihrig @addaleax
test: increase getReport() coverage
e8995d1 
PR-URL: #26276
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Mar 4, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@richardlau richardlau richardlau approved these changes

Assignees
No one assigned
Labels
process Issues and PRs related to the process subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cjihrig @nodejs-github-bot @jasnell @richardlau